Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 57 #1519

Closed
axpoems opened this issue Mar 29, 2024 · 5 comments
Closed

For Cycle 57 #1519

axpoems opened this issue Mar 29, 2024 · 5 comments
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@axpoems
Copy link

axpoems commented Mar 29, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 10377.36
  • USD requested: 22000
  • BSQ rate: 2.12 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 56 #1494

Contributions delivered

Title Team USD Link Notes
Bisq 2 PR Review:
#1698
dev bisq-network/bisq2#1698 ACK
Nit. I have seen that occasionally we are getting scrollbar detected when it shouldn't
(…)
Bisq 2 PR:
Fix misaligned offerbook messages
dev bisq-network/bisq2#1704 In recent changes all the message elements were refactored and now all elements are added in contentVBox instead of the component itself.This was missing to update for messages of type offer.
Bisq 2 PR:
Introduce the first iteration of the new user avatars - The Bisq 2 CatHash
dev bisq-network/bisq2#1705 Resolves #1625
• Introduce the Cathash images. (*)
• Prepare Cathash image set.
• Add configuration to generate the user avatars.
Bisq 2 PR Review:
#1706
dev bisq-network/bisq2#1706 ACK
Nice improvements! Now this is much more flexible when it comes to number of images and buckets.
Bisq 2 PR:
Fix hidden text in report to moderator popup
dev bisq-network/bisq2#1710
Bisq 2 PR:
Add offers' filter dropdown menu in BisqEasy Offerbook
dev bisq-network/bisq2#1717 Fix Add popup to confirm "Ignore user" action #1548
• Add warning before applying 'Ignore user' action
• Add filter offers dropdown menu.
• Misc refactors.
Bisq 2 PR:
Revisit styles of Bisq Easy offer messages
dev bisq-network/bisq2#1731 Towards #1718
• Relocate reputation to be nearer and alongside the user avatar.
• Reduce size of takeOfferButton size and moved it closer to the offer text details.
• Decrease font size of the message bubble and increase line spacing.
• Change colour of the my message bubble to a dark desaturated green.
Bisq 2 PR:
Add additional filter in Bisq Easy Offerbook to filter offers by peer reputation
dev bisq-network/bisq2#1732 Towards #1572
• Add filter by peer reputation
• Rename "offers filter" to offerDirectionOrOwnerFilter, reorder its items and change strings
• Rename the remaining robohash to cathash.
• Fix dropdown menu items sometimes missing to be resized on first run.
Bisq 2 PR:
Update offerbook according to new revision
dev bisq-network/bisq2#1734 Based on #1732
Towards #1718
• Update market channel selector and header titles.
• Place create offer button into the offerbook header.
• Place offerbook search box into the subheader.
Bisq 2 PR Review:
#1738
dev bisq-network/bisq2#1738 ACK
Good catch! Added one comment.
(…)
Bisq 2 PR:
Apply dimming effect to fiat logos and market titles
dev bisq-network/bisq2#1741 Towards #1718
• Apply dimming effect to fiat logos and market titles.
• Highlight selected items in sort and filter dropdown menus (including reputation and offer types).
• Remove unused code.
Bisq 2 PR Review:
#1748
dev bisq-network/bisq2#1748 ACK
Nice changes!
From the UX perspective, I don't see the need for the user to be responsible (or partly responsible) for retrying the messages - especially in the case of ProtocolLogMessages.
What about having a cron job that retries these messages? At least for protocol type of message.
Bisq 2 PR Review:
#1750
dev bisq-network/bisq2#1750 ACK
I looked into this more. It fails every time you create an offer and then switch markets and attempt to create a new one there.
The issue was that the price quote was not being reset property.
I added the fix for this in #1755
Bisq 2 PR:
Add display hint for applied market filers
dev bisq-network/bisq2#1751 Resolves Display a hint about filters being applied to offerbook channel list #1740
• Add display hint for applied market filers.
• Set show All markets by default.
• Adjust the dimming effect, remove on market titles and reduce it for market logos.
Bisq 2 PR Review:
#1754
dev bisq-network/bisq2#1754 Requested changes
A few things: You need to sign your commits, also try to follow the Bisq guidelines when making commits and use the style conventions.
You can read more about this in the contributing guide as well as the developer guidelines.
Bisq 2 PR:
Fix TradeWizardPriceController throwing exception
dev bisq-network/bisq2#1755 Based on #1750
Price controller was throwing an exception upon percentage validation
It worked well while creating offers in one market, but when switching markets and creating a new offer it failed since it was using the previous quote price. Thus, this resets the missing fields every time we use the TradeWizard.
Bisq 2 PR:
Review general code guidelines
dev bisq-network/bisq2#1761 • Added curly brace and ternary operator used styles.
Bisq 2 PR:
Improve user avatars design
dev bisq-network/bisq2#1777 Resolves #1765
• Increase background diameter.
• Create and add new background overlay patterns.
• Add body layer with two size options.
• Add chest and overlay layers with two size options.
• Correct design bug in ears to distinguish from a background with the same colour.
• Add full colour spectrum for the small and bigger ears.
• Add four new face shapes.
• Create new face overlays and fix existing ones according to new face shapes.
• Adapt CatHash algorithm to the new design scheme.
Bisq 2 PR:
Refactor Cathash encoding
dev bisq-network/bisq2#1781 Based on #1777
• Remove unnecessary ordered map.
• Use Optional instead of checking null.
Bisq 2 PR:
Add number of notifications pending to be read in private chats
dev bisq-network/bisq2#1786 Resolves #1774
• We have the global notification count in private chats (sum of all the unread notifications).
• This introduces the notification count per chat inside the tab.
Bisq 2 PR:
Add versioning for avatar image creation
dev bisq-network/bisq2#1791 Setting a property to UserProfile to keep track of the implementation of BucketConfig needed to recreate the user avatar image.
This allows for future improvements in the current CatHash solution.
Bisq 2 PR:
Delete unused robohash images
dev bisq-network/bisq2#1792
Bisq 2 PR:
Rename existing bucket config to match version 0
dev bisq-network/bisq2#1800 Based on #1797
Bisq 2 PR:
Fix user profile selection not working after adding new profile bug
dev bisq-network/bisq2#1811 Fix #1807
• Add missing listener to userProfiles
• Refactors in UserProfileSelection
Bisq 2 PR:
Fix inconsistent market logo effect bug
dev bisq-network/bisq2#1814 Resolves: Selected market does not match with lit market icon #1802
• Fix market logo effect not matching selected row.
• Make updateItem() from markets table decide when to lit the market logo depending on whether that row is selected or not.
• Minor refactors.
Bisq 2 PR:
Keep market item selected while and after using search bug
dev bisq-network/bisq2#1816 Based on #1814
• Add listener to search predicate to always keep selection visible in table view.
• Prior to this, both during and after search, the selection marker disappeared.
Bisq 2 PR:
Add favourites system to offerbook markets enhancement
dev bisq-network/bisq2#1817 Based on #1816
• Add capability to store favourite markets in user settings.
• Use market favourites in offerbook as a way to pin markets.
• Introduce new icons dedicated to favourites.
Bisq 2 PR Review:
#1825
dev bisq-network/bisq2#1825 ACK
Bisq 2 PR Review:
#1826
dev bisq-network/bisq2#1826 ACK
Bisq 2 PR:
Update Bisq Easy texts according to new protocol
dev bisq-network/bisq2#1831 Resolves #1743
• Update trade rules
• Update reject trade warning message
• Update cancel trade warning message
Bisq 2 PR Review:
#1832
dev bisq-network/bisq2#1832 ACK
I reviewed and updated it in #1846
Bisq 2 PR:
Review and update take-offer status feedback overlay
dev bisq-network/bisq2#1846 Based on #1832
• Use as waiting icon the Bisq Easy logo.
• Show take-offer state for at least 8 seconds (less than that the user is not able to read and looks confusing).
• Unify overlays so that we don't see interruption between them.
Bisq 2 PR:
Improve style of matching offers table in trade wizard
dev bisq-network/bisq2#1868 Resolves #1833
• Change matching offers table styles to match the standard style of tables used in the app.
• Add selection marker column.
• Remove unnecessary and confusing column used to select offer.
• Minor refactors.
Bisq 2 PR:
Improve visibility of messages with scroll down indicator
dev bisq-network/bisq2#1869 Resolves #1776
• Apply a gradient buffer when scroll down icon is shown to make a smooth disappearance and improve experience.
• Change icons to better fit the scroll down icon and number of messages indicator in the chat window.
Bisq 2 PR:
Add "Only favourites" filter and other improvements
dev bisq-network/bisq2#1872 • Add "Only favourites" filter.
• Set height correctly for favourite markets and improve paddings.
• Show selected market after applying a new filter to market channel items list.
• Hide horizontal scrollbar in private chats list.
Bisq 2 PR:
Add alert banner to deliver Bisq offical communications
dev bisq-network/bisq2#1880 Based on #1872
• Resolves #1877
• Adds dedicated component to show alerts.
Bisq 2 PR:
Introduce Bisq broadcast icon
dev bisq-network/bisq2#1887 Based on #1882
• Add Bisq boradcast icon to alert banner.
• Change banner's warning background colour.
• Change headline font.
Bisq 2 PR:
Improve published users indicator
dev bisq-network/bisq2#1908 Based on #1896
• Use published instead of active and specify that it refers to profiles in the title label.
• Use tooltip icon and update string to better explain when a profile is published and that this is tight to the user.
Bisq 2 PR:
Improve reputation import account age instructions
dev bisq-network/bisq2#1917 Resolves #1834
• Improve instructions flow.
• Update request authorization to get the value from the model instead of the clipboard.
Bisq 2 PR:
Updates in icons
dev bisq-network/bisq2#1930 Towards issue #1211
• Use MaterialTextArea instead of field in import account age instructions.
• Add new chevron icons (plus missing in white chevron) for the dropdown menus.
• Correct design flaw in small ellipsis icon.
• Improve help icon for better visibility.
• Add mini close icons for the display hints to avoid rescaling.
Bisq 2 PR:
Fix alert banner paddings
dev bisq-network/bisq2#1937 • Move alert notification management to a separate service.
• Fix paddings when showing an alert banner (both in the general case and when colliding with another Bisq Easy notification).
dev 22000 Total

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Mar 29, 2024
@axpoems
Copy link
Author

axpoems commented Mar 29, 2024

05b4ca8635762433ff1320aaabbe9c8abd4d120a69719e4450ddcd79c6260457

@MwithM MwithM added this to the Cycle 57 milestone Apr 15, 2024
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 15, 2024
@ghost
Copy link

ghost commented Apr 15, 2024

Issuance cannot be displayed as there were errors in the comp request

@MwithM MwithM added was:accepted Indicates that a compensation request was accepted by DAO voting and removed was:accepted Indicates that a compensation request was accepted by DAO voting labels Apr 15, 2024
@ghost
Copy link

ghost commented Apr 15, 2024

Issuance cannot be displayed as there were errors in the comp request

@MwithM MwithM removed the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 15, 2024
@ghost
Copy link

ghost commented Apr 15, 2024

Issuance by Team:

team amount BSQ amount USD
dev 10377.36 22000.00

Total Issuance: 10377.36 BSQ (equivalent to: 22000.00 USD)

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 15, 2024
@MwithM
Copy link
Contributor

MwithM commented Apr 15, 2024

Closed as accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

2 participants