You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seller cannot see their own offer in offerbook if trade amount is higher than their current (buy side) account limit and the "Offers matching my accounts" toggle is enabled
#7204
Open
cbeams opened this issue
Jul 17, 2024
· 0 comments
Create a sell offer for an amount higher than the new account buy limits
Notice the offer creation succeeds and shows up in Portfolio > My Open Offers
Now go to Market > Buy, select EUR in currency filter, select Show all in payment method filter, and enable the Offers matching my accounts toggle
Notice that the offer created in step 2 (the user's own offer) does not show up in the list as expected
Uncheck the Offers matching my accounts toggle
Notice that the offer created in step 2 now shows up as originally expected, with its Remove and Edit buttons, etc.
Analysis:
The reason the user's own offer didn't show up in step 4 is because their account is still so new that they "could not take their own sell offer", and thus the offer gets hidden. It makes sense why this is happening, and it's arguably not a "bug" per se, but it is unintuitive, and took me several minutes to figure out what was really going on. I think it does actually qualify as a bug, though, because even if the account was old enough / signed enough, it would still never be the case that the user can take their own offer. The "buy" button does not even appear, only the Remove and Edit buttons.
Suggested fix:
It might require some special case handling, but I think that, so long as the offer book filter includes currency and payment method for a user's own offer, the offer should always show up, regardless whether the "Offers matching my accounts toggle" is enabled. This way, the user will always see their own offer when they would reasonably expect to.
The text was updated successfully, but these errors were encountered:
This is an edge case I'd never seen before today.
Repro steps:
Portfolio > My Open Offers
Market > Buy
, selectEUR
in currency filter, selectShow all
in payment method filter, and enable theOffers matching my accounts
toggleOffers matching my accounts
toggleAnalysis:
The reason the user's own offer didn't show up in step 4 is because their account is still so new that they "could not take their own sell offer", and thus the offer gets hidden. It makes sense why this is happening, and it's arguably not a "bug" per se, but it is unintuitive, and took me several minutes to figure out what was really going on. I think it does actually qualify as a bug, though, because even if the account was old enough / signed enough, it would still never be the case that the user can take their own offer. The "buy" button does not even appear, only the Remove and Edit buttons.
Suggested fix:
It might require some special case handling, but I think that, so long as the offer book filter includes currency and payment method for a user's own offer, the offer should always show up, regardless whether the "Offers matching my accounts toggle" is enabled. This way, the user will always see their own offer when they would reasonably expect to.
The text was updated successfully, but these errors were encountered: