Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PET recon parameter error - need to implement a conditional statement #1897

Closed
CPernet opened this issue Feb 23, 2024 · 6 comments · Fixed by #1906
Closed

PET recon parameter error - need to implement a conditional statement #1897

CPernet opened this issue Feb 23, 2024 · 6 comments · Fixed by #1906

Comments

@CPernet
Copy link
Contributor

CPernet commented Feb 23, 2024

Behaviour

  • ReconMethodParameterLabels: "none"
    (ReconMethodParameterUnits, ReconMethodParameterValues not present)

expected

  • pass

current

  • error: should have properties ReconMethodParameterUnits, ReconMethodParameterValues when property ReconMethodParameterLabels is present

the spec says: RECOMMENDED, but ReconMethodParameterUnits & ReconMethodParameterValues not in the metadata as REQUIRED if ReconMethodParameterLabels does not contain "none"

@CPernet
Copy link
Contributor Author

CPernet commented Feb 23, 2024

behaviour

  • meta.ReconFilterType: "none"
    (ReconFilterSize not present)

expected

  • pass

current

  • error: should have required property 'ReconFilterSize'

the spec says: RECOMMENDED, but REQUIRED if ReconFilterType is not "none"

For instance https://github.com/bids-standard/bids-examples/blob/master/pet001/sub-01/ses-01/pet/sub-01_ses-01_trc-CIMBI36_pet.json#L36 could be removed and be valid (but isn't)

@CPernet
Copy link
Contributor Author

CPernet commented Feb 23, 2024

@rwblair @mnoergaard I'mguessing it's an update in the schema to do?
@tsalo how do we encode a conditional statement? I think that's all we need

@bendhouseart
Copy link
Contributor

I'm going to add a new entry to bids-examples to reflect this case @rwblair as that feels like a good first step.

@tsalo
Copy link
Member

tsalo commented Feb 26, 2024

The schema seems to match the described rules. Is this maybe a bug in the old, non-schema validator?

@CPernet
Copy link
Contributor Author

CPernet commented Feb 26, 2024

i used the online validator ??

@bendhouseart
Copy link
Contributor

Added example to bids-examples in this PR -> bids-standard/bids-examples#427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants