From ec2ebbd42e439c43eb9d941e1e5275452e700ef7 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Thu, 29 Aug 2024 16:19:56 -0400 Subject: [PATCH 1/2] fix(schema): Authors is recommended if CITATION.cff is absent --- src/schema/rules/dataset_metadata.yaml | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/schema/rules/dataset_metadata.yaml b/src/schema/rules/dataset_metadata.yaml index 1a702baa37..d4ecca7da1 100644 --- a/src/schema/rules/dataset_metadata.yaml +++ b/src/schema/rules/dataset_metadata.yaml @@ -8,13 +8,8 @@ dataset_description: DatasetType: recommended License: recommended Authors: - level: recommended - issue: - code: NO_AUTHORS - message: | - The Authors field of dataset_description.json should contain an array of fields - - with one author per field. This was triggered because there are no authors, which - will make DOI registration from dataset metadata impossible. + level: optional + level_addendum: recommended if no CITATION.cff file is present Acknowledgements: optional HowToAcknowledge: optional Funding: optional @@ -24,6 +19,20 @@ dataset_description: GeneratedBy: recommended SourceDatasets: recommended +dataset_authors: + selectors: + - path == "/dataset_description.json" + - '!exists("CITATION.cff", "dataset")' + fields: + Authors: + level: recommended + issue: + code: NO_AUTHORS + message: | + The Authors field of dataset_description.json should contain an array of fields - + with one author per field. This was triggered because there are no authors, which + will make DOI registration from dataset metadata impossible. + derivative_description: selectors: - path == "/dataset_description.json" From eab2a67eccda5fc4994f6357537dc9d029e265bb Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Fri, 30 Aug 2024 10:56:50 -0400 Subject: [PATCH 2/2] Update Authors recommendation level in table --- src/modality-agnostic-files.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modality-agnostic-files.md b/src/modality-agnostic-files.md index c6890aa6b4..b93ee17638 100644 --- a/src/modality-agnostic-files.md +++ b/src/modality-agnostic-files.md @@ -34,7 +34,7 @@ and a guide for using macros can be found at "DatasetLinks": "REQUIRED if [BIDS URIs][] are used", "DatasetType": "RECOMMENDED", "License": "RECOMMENDED", - "Authors": "RECOMMENDED", + "Authors": "RECOMMENDED if CITATION.cff is not present", "Acknowledgements": "OPTIONAL", "HowToAcknowledge": "OPTIONAL", "Funding": "OPTIONAL",