This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Streaming Downloads read the entire contents into memory #167

Open

KAllan357 opened this issue Jun 7, 2013 · 1 comment

Labels

bug

Contributor

KAllan357 commented Jun 7, 2013

Noticed this while working on some similar code for a different library.

The line linked here - https://github.com/RiotGames/ridley/blob/master/lib/ridley/connection.rb#L146 - will read the entire contents into memory.

Contributor

lamont-granquist commented Oct 19, 2016

probably still an issue here:

ridley/lib/ridley/connection.rb

Line 149 in 385bfd9

body = remote.read

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.