Skip to content
This repository has been archived by the owner on Oct 27, 2023. It is now read-only.

Install hook uses only one helm binary to check its version #98

Open
archi144 opened this issue Jun 14, 2022 · 0 comments
Open

Install hook uses only one helm binary to check its version #98

archi144 opened this issue Jun 14, 2022 · 0 comments

Comments

@archi144
Copy link

Hello!
Thank you for that convinient plugin!

Issue:
When I install helm-push-artifactory-plugin install hook script uses helm binary (see) to get its version.
I have helm 2 binaries on my system: helm and helm3.
I can't install this plugin for helm3 binary because script always gets version from helm binary.
I understand I can temporary rename binaries and sucessfully install the plugin.
It doesn't look like a solution for me, though.
I propose to change install hook a bit like that:

supported_helm_version="v3"

HELM_BINARY=${HELM_BINARY="helm"}

helm_version="$($HELM_BINARY version | grep "Version" | cut -d '"' -f 2 | cut -d '.' -f 1)"
...

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant