Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add currency rate exchange endpoint #548

Open
franzns opened this issue Dec 1, 2023 · 1 comment
Open

add currency rate exchange endpoint #548

franzns opened this issue Dec 1, 2023 · 1 comment
Labels
good first issue Good for newcomers
Milestone
Support for front...

Comments

@franzns
Copy link
Contributor

franzns commented Dec 1, 2023 •
edited
Loading

we would like to be able to switch currencies and the frontend wants to pull exchange rates from the api. We need to query and store exchange rate for an external provider and offer a query endpoint
@franzns
Copy link
Contributor Author

franzns commented Dec 1, 2023

https://github.com/balancer/frontend-v3/blob/main/lib/shared/utils/currencies.ts#L31-L43

  • we return the full list in the query
  • add eth and btc price to the list (at query time, not to the DB, so it stays up to date)
  • re-query every 10mins to stay in request limits

@franzns franzns added this to the Support for frontend v3 milestone Dec 13, 2023
@franzns franzns added the good first issue Good for newcomers label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Support for frontend v3
Development

No branches or pull requests
1 participant
@franzns