Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some asset images are excessively large #2226

Open
ReflectiveChimp opened this issue Jun 26, 2024 · 2 comments
Open

Some asset images are excessively large #2226

ReflectiveChimp opened this issue Jun 26, 2024 · 2 comments

Comments

@ReflectiveChimp
Copy link
Collaborator

ReflectiveChimp commented Jun 26, 2024

PNGs can be resized down to 128x128 if larger and losslessly compressed
SVGs can be losslessly compressed (e.g. with SVGO)

128K ./src/images/single-assets/wBaseDOGE.png
131K ./src/images/single-assets/RETRO.svg
131K ./src/images/single-assets/oRETRO.svg
145K ./src/images/single-assets/crvUSDBTCETH3.svg
169K ./src/images/single-assets/RPL.png
177K ./src/images/single-assets/NORMUS.png
222K ./src/images/single-assets/PEARL.png
377K ./src/images/single-assets/hDAI.png
379K ./src/images/single-assets/hUSDT.png
383K ./src/images/single-assets/hSNX.png
396K ./src/images/single-assets/hETH.png
401K ./src/images/single-assets/hUSDC.png
471K ./src/images/single-assets/AERO.svg
559K ./src/images/single-assets/weETH.png
@DefiDebauchery
Copy link
Member

DefiDebauchery commented Jul 3, 2024

Should it be added to pre-commit hooks, or is it good enough to do once-off ops?

Similarly, should we use 384 instead (128 x3 for hi-dpi screens)? I was able to get weETH to 55K at 384, for instance. Not sure where we're even using this asset, though; I only see the SVG in use.

@ReflectiveChimp
Copy link
Collaborator Author

ReflectiveChimp commented Jul 26, 2024

Once off will do. [A precommit that checked the file sizes could be useful though]
Largest they are displayed in app is 48x48.
If there is X.svg and X.png in single-assets/ then X.png can be deleted as app will pick the .svg over the .png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants