Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Getting notifications meant for others #17

Open
vuldin opened this issue Jan 12, 2018 · 8 comments
Open

Getting notifications meant for others #17

vuldin opened this issue Jan 12, 2018 · 8 comments

Comments

@vuldin
Copy link

vuldin commented Jan 12, 2018

fritter-notifications

Clicking on 'Notifications' shows me three notifications from Andre Staltz for three different posts by Tim Caswell. I'm currently following Andre but not (yet) Tim, and I haven't interacted with those posts in any before seeing them in my Notifications.
@pfrazee
Copy link
Member

pfrazee commented Jan 12, 2018

I've seen this myself. Seems like in some cases the notifications index gets built without having the user's id set, causing this.

@alterx
Copy link

alterx commented Jan 13, 2018

Same happened to me, had to manually remove the notifications. What's interesting is that these were the same three posts 🤔

@paul90
Copy link

paul90 commented May 5, 2018

Same just happened to me...

screen shot 2018-05-05 at 07 31 54

The data in Tara's post looks OK

{
  "text": "Check it out y'all, we finally have mentions on here thanks to @Sander ! ",
  "createdAt": 1525403903948,
  "mentions": [
    {
      "name": "Sander",
      "url": "dat://14e02bfbe6d66113327a1e2f473dcd639dc3d9d97a05c1e5778a6c295fd02095"
    }
  ]
}

I don't see anything obvious in the libfritter code...

@paul90
Copy link

paul90 commented May 5, 2018

I've narrowed it down to a problem in

  function isAMentionOfUser (record) {
    return record.hasOwnProperty('mentions') && record.mentions.find(x => {
      return x.url == inst.userUrl
    })
}

it looks as if the value returned from the function in the find is not available. The response from record.mentions.find(x => { return x.url == inst.userUrl }) appears to be undefined, rather than true or false.

@paul90
Copy link

paul90 commented May 5, 2018

There is a note in beakerbrowser/libfritter#4 on what was happening, and how the fix works.

@pfrazee
Copy link
Member

pfrazee commented May 5, 2018

Ok I think we've solved this. Fingers crossed.

@pfrazee
Copy link
Member

pfrazee commented May 5, 2018

Thanks @paul90

@brechtcs
Copy link
Contributor

brechtcs commented Nov 10, 2018

I created a new profile to give Fritter another go yesterday, and the same thing happened to me:

fritter-notifications-bug

I've been seeding Fritter for a while, so maybe I'm still using an older version. The most recently update seems to be from June, and the url is dat://9900f9aad4d6e79e0beb1c46333852b99829e4dfcdfa9b690eeeab3c367c1b9a.

Edit: Aha, just noticed in the settings screen it says "Fritter build 2018.06.14"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants