support mmdebstrap's --format option

[Infinoid]

Hi,

I like the idea of bdebstrap, so I tried it out today. However, it doesn't seem to capture my usage of mmdebstrap.

I tried to put my mmdebstrap parameters into a yaml format and run it with bdebstrap, and found that the --format parameter is not supported as a yaml key. I tried this input:

---
mmdebstrap:
  architectures:
    - arm64
  suite: bookworm
  target: tmp/root.ext2
  format: ext2
  variant: minbase
  mode: unshare
  packages:
    - openssh-server
    - netplan.io
    - libpam-systemd

And I got this output:

2022-11-05 14:29:14,223 bdebstrap WARNING: Ignoring unknown mmdebstrap option 'format'.

The parameter exists, and it works when I run mmdebstrap directly. Here's the mmdebstrap documentation. Is it possible for bdebstrap to pass it through somehow?

I was expecting it to run something similar to this:

mmdebstrap --architectures=arm64 --variant=minbase --format=ext2 --mode=unshare --include=openssh-server,netplan.io,libpam-systemd bookworm tmp/root.ext2

Thanks!

[Infinoid]

For context, the reason I wanted to specify the format was because my goal was ext4, not ext2.

When I run mmdebstrap, I have it create an ext2 file named root.ext4, and then upgrade it to ext4 with tune2fs as described in the mmdebstrap docs.

That filename doesn't end in ".ext2", so it only works when specifying the format manually.

Also, that tune2fs command would work nicely as a post-imaging hook, if such things existed. (cleanup-hooks won't work, as those run prior to the tempdir being packed into a squashfs/ext2 image.)

[bdrung]

Thanks for reporting this bug. I have pushed a fix in the format branch. Please test.

Sadly the getext2fs does not support extended attributes (see bestouff/genext2fs#9).

Have you filed a bug for mmdebstrap to add a post-imaging hook?

[Infinoid]

Have you filed a bug for mmdebstrap to add a post-imaging hook?

No. I was just thinking out loud.

I'm not even sure it would be within the scope of mmdebstrap. It's easy enough to put it in a script that runs after mmdebstrap/bdebstrap finishes, after all.

[Infinoid]

Thanks for reporting this bug. I have pushed a fix in the format branch. Please test.

I tested the format branch, and it worked as expected. I updated my config to say:

  format: ext2
  target: rootfs

Then ran: ./bdebstrap -c conf/test.yaml -n build/rootfs

and the result worked perfectly.

% ls -l build/rootfs
total 413896
-rw-r--r-- 1 infinoid infinoid      1217 Nov  5 21:35 config.yaml
-rw-r--r-- 1 infinoid infinoid      3621 Nov  5 21:35 manifest
-rw-r--r-- 1 infinoid infinoid 463244288 Nov  5 21:35 rootfs
% file build/rootfs/rootfs
build/rootfs/rootfs: Linux rev 1.0 ext2 filesystem data, UUID=00000000-0000-0000-0000-000000000000

Thanks for the quick fix!

[bdrung]

Merged the fix to main and released bdebstrap 0.5.0.