Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel vendor ignores --target_pattern_file #23628

Closed
lalten opened this issue Sep 16, 2024 · 2 comments
Closed

bazel vendor ignores --target_pattern_file #23628

lalten opened this issue Sep 16, 2024 · 2 comments
Assignees
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug type: feature request

Comments

@lalten
Copy link
Contributor

lalten commented Sep 16, 2024

Description of the bug:

bazel vendor ignores --target_pattern_file and behaves as if no target pattern had been passed

Which category does this issue belong to?

External Dependency

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

release 7.3.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Sep 16, 2024
@meteorcloudy meteorcloudy added type: feature request P1 I'll work on this now. (Assignee required) and removed untriaged labels Sep 17, 2024
@meteorcloudy meteorcloudy self-assigned this Sep 17, 2024
@meteorcloudy meteorcloudy added the area-Bzlmod Bzlmod-specific PRs, issues, and feature requests label Sep 17, 2024
@meteorcloudy
Copy link
Member

@bazel-io fork 7.4.0

@meteorcloudy
Copy link
Member

Thanks for reporting! I'm sending a fix and backport it to 7.4.0

bazel-io pushed a commit to bazel-io/bazel that referenced this issue Sep 18, 2024
Fixes: bazelbuild#23628

RELNOTES: Bazel fetch and vendor command now supports --target_pattern_file for specifying target patterns.

Closes bazelbuild#23640.

PiperOrigin-RevId: 676063442
Change-Id: Ibbbf7879dfec4ec10093631fb002f87c9dddc8ef
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
…23663)

Fixes: #23628

RELNOTES: Bazel fetch and vendor command now supports
--target_pattern_file for specifying target patterns.

Closes #23640.

PiperOrigin-RevId: 676063442
Change-Id: Ibbbf7879dfec4ec10093631fb002f87c9dddc8ef

Commit
3120d35

---------

Co-authored-by: Yun Peng <[email protected]>
Co-authored-by: Xùdōng Yáng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants