Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] No longer eagerly fetch labels in repo rule attributes #23372

Closed
bazel-io opened this issue Aug 20, 2024 · 3 comments
Closed

[7.4.0] No longer eagerly fetch labels in repo rule attributes #23372

bazel-io opened this issue Aug 20, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23371
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Aug 20, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
src/test/shell/bazel/starlark_prefetching_test.sh

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java src/test/shell/bazel/starlark_prefetching_test.sh

cc: @bazelbuild/triage

cc: @fmeum @Wyverald @meteorcloudy

@fmeum fmeum mentioned this issue Aug 22, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23389

github-merge-queue bot pushed a commit that referenced this issue Aug 24, 2024
@fmeum @dws @Silic0nS0ldier
[7.4.0] Repo context cherry-picks (#23389)
f1a1f2d 
Cherry-picks the following commits:
* Clarify /rules/lib/builtins/repository_ctx description of default
working_directory for execute()
(fa2fbcd)
* Normalize repository starlark API docs
(8f16990)
* Document source of truth for `rctx.download*` cache key
(d4b416f)
* Make `get_default_canonical_id` public
(6052ad6)
* No longer eagerly fetch labels in repo rule
(6fabb1f)

Closes #23372

---------

Co-authored-by: David Sanderson <[email protected]>
Co-authored-by: Jordan Mele <[email protected]>
Co-authored-by: Jordan Mele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @bazel-io @iancha1992