Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Fix in-process materialization of unresolved symlinks in runfiles #23329

Closed
bazel-io opened this issue Aug 18, 2024 · 3 comments
Closed

[7.4.0] Fix in-process materialization of unresolved symlinks in runfiles #23329

bazel-io opened this issue Aug 18, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23328
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Aug 18, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/starlark/builtins_bzl/common/builtin_exec_platforms.bzl

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/starlark/builtins_bzl/common/builtin_exec_platforms.bzl

cc: @bazelbuild/triage

cc: @tjgq @fmeum

@fmeum fmeum mentioned this issue Aug 22, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23391

github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2024
@fmeum
[7.4.0] Fix in-process materialization of unresolved symlinks in runf…
069dd38 
…iles (#23391)

Unresolved symlinks, when consumed as runfiles with
`--experimental_inprocess_symlink_creation`, are now created as symlinks
directly pointing to their target path instead of to the absolute path
of the unresolved symlink artifact under the execroot, just like with
out-of-process symlink creation.

Along the way, fix the propagation of
`--experimental_inprocess_symlink_creation` to the exec configuration,
which previously would have caused the new test cases to fail open.

Fixes #23327

Closes #23328.

PiperOrigin-RevId: 665754549
Change-Id: I6b240ca27dac513738056b015c97baec91677c4e

Closes #23329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992