In-process symlink creation doesn't materialize unresolved symlinks as such #23327
Assignees
Labels
P1
I'll work on this now. (Assignee required)
team-Local-Exec
Issues and PRs for the Execution (Local) team
type: bug
Comments
fmeum
added
P1
fmeum
added a commit
to fmeum/bazel
that referenced
this issue
Aug 22, 2024
Unresolved symlinks, when consumed as runfiles with `--experimental_inprocess_symlink_creation`, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation. Along the way, fix the propagation of `--experimental_inprocess_symlink_creation` to the exec configuration, which previously would have caused the new test cases to fail open. Fixes bazelbuild#23327 Closes bazelbuild#23328. PiperOrigin-RevId: 665754549 Change-Id: I6b240ca27dac513738056b015c97baec91677c4e
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2024
…iles (#23391) Unresolved symlinks, when consumed as runfiles with `--experimental_inprocess_symlink_creation`, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation. Along the way, fix the propagation of `--experimental_inprocess_symlink_creation` to the exec configuration, which previously would have caused the new test cases to fail open. Fixes #23327 Closes #23328. PiperOrigin-RevId: 665754549 Change-Id: I6b240ca27dac513738056b015c97baec91677c4e Closes #23329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would just like to point out this breaking issue with
rules_jsthat I found when--experimental_inprocess_symlink_creationis turned on in Bazel 7.2.Unsure if its Bazel, or the rules that aren't vibing with this in the way that is expected, but the rule set is popular enough you may want to see it resolved first.
I suspect I'm the first-mover to come across this.
Here is the ticket: aspect-build/rules_js#1877
Originally posted by @adamscybot in #4327 (comment)
The text was updated successfully, but these errors were encountered: