Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode overwriting not working #17

Open
jamieisboss opened this issue Sep 22, 2014 · 4 comments
Open

Shortcode overwriting not working #17

jamieisboss opened this issue Sep 22, 2014 · 4 comments

Comments

@jamieisboss
Copy link
Contributor

I am attempting to use the shortcodes [featured_products] and [recent_products] in my theme but they are not showing any of the bootstrap classes and look exactly as they would without the plugin. I've also tried adding content_product_template as in one of thr examples in the readme, but to no avail, a snippet of my code is below:

<?php echo do_shortcode('[featured_products columns="4" per_page="4" content_product_template="bs-content-product-info"]'); ?>

I am currently running WooCommerce 2.2.4 (most recent version) which I've noticed isn't the supported version in the readme, and might well be the reason this isn't working now. Is there anything I can do to get this going?

Thanks

Jamie

@lincolnlemos
Copy link
Contributor

Hey @jamieisboss , can you do this work?

@jamieisboss
Copy link
Contributor Author

In the end i just wrote some functions to display the content the way we wanted to here's a gist of it:

https://gist.github.com/jamieisboss/a4a3f4e40a663dc04dff

I actually started rewriting this plugin from the ground up but got completeley sidetracked. I think I'll finish that off soon because i want it to integrate with woocommerce the way they suggest and i'll be wanting to move to bootstrap 4.

Looking at the code now though i actualy think i know why it stopped working and how to fix it, gimme a sec...

@jamieisboss
Copy link
Contributor Author

Yeah, a sec, lol, submitted a pull request which i think should fix it, cant tst myself though so ... dont know, if its not accepted i'll build a little test copy and test properly en ive got a bit more time. I forgot how complicated changing the woocommerce behaviour is.

@lincolnlemos
Copy link
Contributor

Ok.. thx for share.
I will use the functions atm..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants