Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak_ensemble has incorrect dependencies [JIRA: RIAK-2129] #82

Open
Basho-JIRA opened this issue Aug 27, 2015 · 3 comments
Open

riak_ensemble has incorrect dependencies [JIRA: RIAK-2129] #82

Basho-JIRA opened this issue Aug 27, 2015 · 3 comments

Comments

@Basho-JIRA
Copy link

The app dependencies in rebar.config and .app.src are not in sync with the actual usage in the application.

This is currently one of the blockers for using the application as a dependency in your own project - at least if you want to use relx and rely on proper OTP rules for releases.
E.g., in riak_ee all the non-OTP applications show up without a version number in the directory name in the lib directory.
This complicates release upgrades a lot.

The fix is to simply bring the files in sync with reality.

The problem and the fix applies to all versions of the application, not just the one listed in the Fix and Affected Version(s) fields.

[Created in JIRA by Torben Hoffmann]

@Basho-JIRA
Copy link
Author

We'll take a look at the PR and get it merged post-2.1.2 - I realize it may be a small change, but we're trying not to pull anything new into 2.1.2 if it's not necessary for the release at this time.

_[posted via JIRA by Douglas Rohrer]_

@Basho-JIRA
Copy link
Author

Don't put it in 2.1.2 - it is not worth the risk.

_[posted via JIRA by Torben Hoffmann]_

@Basho-JIRA
Copy link
Author

Don't put it in 2.1.2 - it is not worth the risk.

Just wanted a placeholder for it.

_[posted via JIRA by Torben Hoffmann]_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant