Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Request: Error in Error Triage Exercise exemplar comments #168

Open
briandoyle81CB opened this issue Nov 30, 2023 · 0 comments
Open

Docs Request: Error in Error Triage Exercise exemplar comments #168

briandoyle81CB opened this issue Nov 30, 2023 · 0 comments
Labels
state: backlog This is pending further review type: docs New docs or changes to existing

Comments

@briandoyle81CB
Copy link
Contributor

What is the issue you are encountering with the docs?

The popWithReturn description incorrectly states it should return the array. It should NOT return the array

Links to Impacted Docs

https://docs.base.org/base-camp/docs/error-triage/error-triage-exercise/

Describe the solution you'd like to see.

Update the comment to read:

/**
 * Pop the last element from the supplied array, and return the popped
 * value (unlike the built-in function)
 */

Additional context

No response
@briandoyle81CB briandoyle81CB added the type: docs New docs or changes to existing label Nov 30, 2023
@jennyg0 jennyg0 mentioned this issue Nov 30, 2023
Merged
@wbnns wbnns added the state: backlog This is pending further review label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: backlog This is pending further review type: docs New docs or changes to existing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wbnns @briandoyle81CB