Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Request: ERC721 Exercise suggestion #147

Open
dimal97 opened this issue Nov 21, 2023 · 1 comment
Open

Docs Request: ERC721 Exercise suggestion #147

dimal97 opened this issue Nov 21, 2023 · 1 comment
Labels
state: backlog This is pending further review type: docs New docs or changes to existing

Comments

@dimal97
Copy link

dimal97 commented Nov 21, 2023 •
edited
Loading

What is the issue you are encountering with the docs?

NFT exercise is great but it seems closer to standard solidity exercise vs showcasing NFTs.

Links to Impacted Docs

https://docs.base.org/base-camp/docs/erc-721-token/erc-721-exercise

Describe the solution you'd like to see.

One idea can be to slightly modify the exercise so that it becomes more end-to-end and the final version can be viewed in Opensea - for example asking to implement tokenUri that returns NFT metadata and renders haiku lines as SVG.

Additional context

No response
@dimal97 dimal97 added the type: docs New docs or changes to existing label Nov 21, 2023
@wbnns wbnns added the state: backlog This is pending further review label Nov 28, 2023
@wbnns
Copy link
Member

wbnns commented Nov 28, 2023

@dimal97

Thanks for taking the time to open this issue. Will leave this open until our team has an opportunity to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: backlog This is pending further review type: docs New docs or changes to existing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wbnns @dimal97