From e549d8dbcd8ddff2727823916ae392113ee85714 Mon Sep 17 00:00:00 2001 From: Mladen Planinicic Date: Wed, 27 Dec 2023 11:56:28 +0100 Subject: [PATCH 1/3] chore(): add text accessibility test --- .../components/bal-text/test/bal-text.cy.html | 2 +- test/cypress/e2e/a11y/bal-text.a11y.cy.ts | 47 +++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 test/cypress/e2e/a11y/bal-text.a11y.cy.ts diff --git a/packages/components/src/components/bal-text/test/bal-text.cy.html b/packages/components/src/components/bal-text/test/bal-text.cy.html index 99ce49050b..6ecf013d61 100644 --- a/packages/components/src/components/bal-text/test/bal-text.cy.html +++ b/packages/components/src/components/bal-text/test/bal-text.cy.html @@ -13,7 +13,7 @@

Basic

- Lorem ipsum dolor sit amet consectetur adipisicing elit. + Lorem ipsum dolor sit amet consectetur adipisicing elit.

Small

diff --git a/test/cypress/e2e/a11y/bal-text.a11y.cy.ts b/test/cypress/e2e/a11y/bal-text.a11y.cy.ts new file mode 100644 index 0000000000..20f89071e1 --- /dev/null +++ b/test/cypress/e2e/a11y/bal-text.a11y.cy.ts @@ -0,0 +1,47 @@ +describe('bal-text', () => { + context('a11y', () => { + beforeEach(() => cy.platform('desktop').pageA11y('/components/bal-text/test/bal-text.cy.html')) + + describe('have the AA standard', () => { + it('basic', () => { + cy.getByTestId('basic').testA11y() + }) + + testColorA11y([ + 'light-blue', + 'blue-dark', + 'blue-light', + 'primary-light', + 'white', + 'black', + 'grey', + 'primary', + 'blue', + 'info', + 'success', + 'danger', + 'warning', + ]) + + testSizeA11y(['block', 'lead', 'small']) + }) + }) +}) + +function testColorA11y(colors: BalProps.BalTextColor[]) { + for (let index = 0; index < colors.length; index++) { + const color = colors[index] + it(`color ${color}`, () => { + cy.getByTestId('basic').setProperty('color', color).testA11y() + }) + } +} + +function testSizeA11y(sizes: BalProps.BalTextSize[]) { + for (let index = 0; index < sizes.length; index++) { + const size = sizes[index] + it(`sizes ${size}`, () => { + cy.getByTestId('basic').setProperty('sizes', size).testA11y() + }) + } +} From cc2f7ebf056a99fbfe96761a99c68e5ea3261dcd Mon Sep 17 00:00:00 2001 From: Mladen Planinicic Date: Tue, 16 Jan 2024 14:04:54 +0100 Subject: [PATCH 2/3] chore(): refactor --- .../bal-text/test/bal-text.a11y.html | 21 +++++++++++++++++++ .../components/bal-text/test/bal-text.cy.html | 2 +- test/cypress/e2e/a11y/bal-text.a11y.cy.ts | 2 +- 3 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 packages/components/src/components/bal-text/test/bal-text.a11y.html diff --git a/packages/components/src/components/bal-text/test/bal-text.a11y.html b/packages/components/src/components/bal-text/test/bal-text.a11y.html new file mode 100644 index 0000000000..5df827f1eb --- /dev/null +++ b/packages/components/src/components/bal-text/test/bal-text.a11y.html @@ -0,0 +1,21 @@ + + + + + + + + + + + + +
+

Basic

+
+ Lorem ipsum dolor sit amet consectetur adipisicing elit. +
+
+ + + diff --git a/packages/components/src/components/bal-text/test/bal-text.cy.html b/packages/components/src/components/bal-text/test/bal-text.cy.html index 6ecf013d61..99ce49050b 100644 --- a/packages/components/src/components/bal-text/test/bal-text.cy.html +++ b/packages/components/src/components/bal-text/test/bal-text.cy.html @@ -13,7 +13,7 @@

Basic

- Lorem ipsum dolor sit amet consectetur adipisicing elit. + Lorem ipsum dolor sit amet consectetur adipisicing elit.

Small

diff --git a/test/cypress/e2e/a11y/bal-text.a11y.cy.ts b/test/cypress/e2e/a11y/bal-text.a11y.cy.ts index 20f89071e1..52e7f529aa 100644 --- a/test/cypress/e2e/a11y/bal-text.a11y.cy.ts +++ b/test/cypress/e2e/a11y/bal-text.a11y.cy.ts @@ -1,6 +1,6 @@ describe('bal-text', () => { context('a11y', () => { - beforeEach(() => cy.platform('desktop').pageA11y('/components/bal-text/test/bal-text.cy.html')) + beforeEach(() => cy.platform('desktop').pageA11y('/components/bal-text/test/bal-text.a11y.html')) describe('have the AA standard', () => { it('basic', () => { From f562ead72ff33966bc347c0a77fe6438cf3e885e Mon Sep 17 00:00:00 2001 From: Mladen Planinicic Date: Thu, 18 Jan 2024 16:57:32 +0100 Subject: [PATCH 3/3] feat(): change warning text color to danger --- packages/tokens/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tokens/src/index.ts b/packages/tokens/src/index.ts index 3d592d2e70..d99ad71fa4 100644 --- a/packages/tokens/src/index.ts +++ b/packages/tokens/src/index.ts @@ -467,7 +467,7 @@ const tokens = { 'primary-light': 'primary-3', // inverted disabled 'success': 'success-4', 'info': 'info-4', - 'warning': 'warning-5', + 'warning': 'danger-4', 'danger': 'danger-4', 'danger-dark': 'danger-5', // hover color 'danger-darker': 'danger-6', // active color