Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v1/device/host-config doesn't allow setting of redsocks "log_debug" #2236

Open
rcooke-warwick opened this issue Jan 31, 2024 · 0 comments
Open

Comments

@rcooke-warwick
Copy link

Right now the /v1/device/host-config endpoint is limited to inly modifying a subset of the redocks configuration fields:

const proxyFields = ['type', 'ip', 'port', 'login', 'password'];

A static base header is always used - with "log_debug = off". The only way to modify this property to enable extra logging is to change the redocks.conf file directly. The issue with this is that further PATCH requests to /v1/device/host-config will overwrite this change with the header here again:

From my understanding we are deliberately limiting what redsocks configuration options can be modified via this endpoint to try to prevent mistakes being made, which could lead to unreachable devices - for example "local_port = 12345 is set, so that the iptables rules and redsocks port match." - however "log_debug = on" is a safe one to allow - so maybe its worth enabling that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant