App restart via API does not respect service dependency in depends_on

[pipex]

The composition service ordering is used when updating between services, but not during service updates. This is due to the supervisor obtaining the services information from the current state, while depends_on only exists in the composition.

balena-supervisor/src/device-api/actions.ts

Lines 93 to 118 in d3f9821

	return await lock(appId, { force }, async () => {
	const currentState = await deviceState.getCurrentState();
	if (currentState.local.apps?.[appId] == null) {
	throw new InternalInconsistencyError(
	`Application with ID ${appId} is not in the current state`,
	);
	}
	const app = currentState.local.apps[appId];
	const services = app.services;
	app.services = [];
	return deviceState
	.applyIntermediateTarget(currentState, {
	skipLock: true,
	})
	.then(() => {
	app.services = services;
	return deviceState.applyIntermediateTarget(currentState, {
	skipLock: true,
	keepVolumes: false,
	});
	})
	.finally(() => {
	deviceState.triggerApplyTarget();
	});
	});

Probably the right approach is to merge the target state with the runtime state to obtain the correct target.

[jellyfish-bot]

[pipex] This has attached https://jel.ly.fish/4f492090-44a9-44c8-bea8-0028f16f6599