Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return release raw_version where possible if returning commit #2159

Open
myarmolinsky opened this issue Apr 14, 2023 · 6 comments
Open

Comments

@myarmolinsky
Copy link

i.e.

'/v2/applications/state',
(if possible)

Forums thread: https://jel.ly.fish/support-thread-discourse-367420
Zulip thread: https://balena.zulipchat.com/#narrow/stream/346010-channel.2Fsupport/topic/curl.20supervisor.20endpoint.20with.20params

@jellyfish-bot
Copy link

[myarmolinsky] This has attached https://jel.ly.fish/f7466cce-927a-42dd-a31c-e4957ddd6a86

@pipex
Copy link
Contributor

pipex commented Apr 20, 2023

This requires an API change first, as the supervisor does not receive the version information via the target state

@rosswesleyporter
Copy link

Another customer requested this, specifically getting release semvar from Supervisor API. See https://balena.zulipchat.com/#narrow/stream/345882-_help/topic/get.20release.20semvar.20from.20Supervisor.20API.3F

@bbugh
Copy link

bbugh commented Mar 16, 2024

Also requesting this.

The thread on the forum suggests using the web API, but we need this during a runtime startup process. If we can get the information from the device itself rather than potentially derailing our startup process because a web API isn't responding, it would be a lot better for us.

@bbugh
Copy link

bbugh commented Mar 16, 2024

It looks like calling the web API also requires including the API token on the devices, but our devices are on-site for the customers. Including a web API token opens us up to security issues we'd rather not deal with.

@pipex
Copy link
Contributor

pipex commented Mar 16, 2024

@bbugh regarding security. Using the io.balena.features.balena-api feature label will give a service access to the device API key, which is what the supervisor uses to communicate to the API and has read-only permissions to the release entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants