Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standardised fork test for deployments to check that it reports the correct task id. #2039

Closed
TomAFrench opened this issue Nov 22, 2022 · 1 comment
Closed

Add standardised fork test for deployments to check that it reports the correct task id. #2039

TomAFrench opened this issue Nov 22, 2022 · 1 comment

Comments

@TomAFrench
Copy link
Contributor

We're going to be deploying contracts with a version string which contains the task id contained within it. It would be a pain to have this be incorrect so we should have a simple method to check beforehand that the task will pass the correct task id to the contract being deployed.
@nventuro nventuro mentioned this issue Nov 23, 2022
Merged
11 tasks
@jubeira jubeira mentioned this issue Jun 1, 2023
Open
@jubeira
Copy link
Contributor

jubeira commented Jun 1, 2023

Moved to balancer/balancer-deployments#41.

@jubeira jubeira closed this as completed Jun 1, 2023
@jubeira jubeira closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jubeira @TomAFrench