Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximal-cliques silently breaks on digraphs #128

Open
flodiebold opened this issue Mar 4, 2020 · 0 comments
Open

maximal-cliques silently breaks on digraphs #128

flodiebold opened this issue Mar 4, 2020 · 0 comments

Comments

@flodiebold
Copy link

E.g.

user> (graph-alg/maximal-cliques (graph/digraph ["a" "b"] ["b" "c"]))
(#{"a" "b"} #{"c"})
user> (graph-alg/maximal-cliques (graph/digraph ["c" "b"] ["b" "a"]))
(#{"a"})

(these graphs are isomorphic.)

Of course Bron-Kerbosch only works on undirected graphs, but silently giving wrong results doesn't seem like the right thing to do here 😄 It'd be nice if it could either work on only the edges that go in both directions (which was what I assumed it would do), or loudly fail, or at least say in the documentation that it won't work.

(Or maybe I have some fundamental misunderstanding here?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant