Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Clojurescript [any Long] issue #107

Open
ClashTheBunny opened this issue Dec 8, 2018 · 2 comments
Open

Possible Clojurescript [any Long] issue #107

ClashTheBunny opened this issue Dec 8, 2018 · 2 comments

Comments

@ClashTheBunny
Copy link

I did Day 6 of Advent of Code with the help of loom! Thanks so much!

I did run into an issue when I ran it in clojurescript:

=== Running clojure test aoc.y2018.d07.ClashTheBunny

Running tests in #{"src"}

Testing aoc.y2018.d07.ClashTheBunny
part-2 took 169.12 msecs
part-1 took 39.93 msecs

Ran 2 tests containing 2 assertions.
0 failures, 0 errors.

=== Running cljs test aoc.y2018.d07.ClashTheBunny
WARNING: cljs.core/bit-or, all arguments must be numbers, got [any Long] instead at line 494 cljs-test-runner-out/loom/alg_generic.cljc

Testing aoc.y2018.d07.ClashTheBunny
part-1 took 66.00 msecs

FAIL in (part-2) (cljs_test_runner.gen.js:768:286)
expected: (= (str answer-2) (str (:timer (solve-2 input 5 60))))
  actual: (not (= "891" "732"))
part-2 took 241.00 msecs

Ran 2 tests containing 2 assertions.
1 failures, 0 errors.

It passes fine in CLJ, but in cljs I get the wrong answer. I am using loom very lightly, so I doubt this is an issue with loom, but I saw the warning and figured you may want to know anyhow.

https://circleci.com/gh/borkdude/advent-of-cljc/235

@ClashTheBunny
Copy link
Author

Just to follow up, I was able to make it work in clojurescript even with the warning, so the warning is 100% cosmetic for my use case.

@johannesloetzsch
Copy link

I just saw that this is the same issue as #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants