Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification always executes the action #3944

Open
ayushjaipuriyar opened this issue Aug 22, 2024 · 7 comments
Open

Notification always executes the action #3944

ayushjaipuriyar opened this issue Aug 22, 2024 · 7 comments

Comments

@ayushjaipuriyar
Copy link

awesome v4.3-1655-gad0290bc1-dirty (Too long)
 • Compiled against Lua 5.4.7 (running with 0.9.2)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: no
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: /usr/share/lua/5.4/lgi/version.lua
 • Transparency enabled: yes
 • Custom search paths: no

How to reproduce the issue:

  • A notification from any app that supports actions, let's say slack.

Actual result:

  • As soon as the notifications arrives, the app is forced to open even when no actions were taken.

Expected result:

  • The notification should just time out if no actions are taken.

This wasn't the case earlier, but in the recent commits this started to happen.

@Elv13
Copy link
Member

Elv13 commented Aug 22, 2024

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

@ayushjaipuriyar
Copy link
Author

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

I am using the new one, as I have that line in my configs.
And yes in bustle, it shows like

  • Notifications arrived
  • 3 seconds have passed, the time I have set as timeout of notifications
  • The notification actions invoked is called
  • the notifications action closed is called.

@numkem
Copy link

numkem commented Aug 26, 2024

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

@ayushjaipuriyar
Copy link
Author

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

could be
we might have been able to figure out which may be causing this
Reddit link
pull request

@Aire-One
Copy link
Member

I think #3906 tries to fix this behavior.

@Elv13
Copy link
Member

Elv13 commented Aug 27, 2024

I merged the PR, please update and retry

@ayushjaipuriyar
Copy link
Author

I merged the PR, please update and retry

Apparently did not fix the issue. Currently, as soon as the timeout of the notification finishes the action is executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants