Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a checksum to the hex address format (ideally similar to EIP55). #1570

Open
github-actions bot opened this issue Sep 18, 2024 · 1 comment
Open

Comments

@github-actions
Copy link

Line: 13

"github.com/ava-labs/avalanchego/ids"
)
// TODO: add a checksum to the hex address format (ideally similar to EIP55).
const AddressLen = 33
// Address represents the 33 byte address of a HyperSDK account
type Address [AddressLen]byte
var EmptyAddress = Address{}

@aaronbuchwald
Copy link
Collaborator

https://github.com/ethereum/ERCs/blob/5a1ad45179a6a95cbcd7be67b904a5e5c679bb07/ERCS/erc-55.md

We should implement a checksum on the address as a bare minimum.

Removed bech32 because it makes the UX worse (don't recognize the same address across different chains) and DevX worse (need to pass around contextual information to display/parse addresses).

For this issue, we should re-evaluate what default address format we want and see about enabling VMs to optionally override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant