Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest_revision shouldn't return an Option, since there is always one #700

Open
rkuris opened this issue Aug 13, 2024 · 0 comments
Open

latest_revision shouldn't return an Option, since there is always one #700

rkuris opened this issue Aug 13, 2024 · 0 comments

Comments

@rkuris
Copy link
Collaborator

rkuris commented Aug 13, 2024 

          Is it an invariant that there is always at least one historical revision? If so, should the return type for `latest_revision` be `Arc<NodeStore<Committed, FileBacked>>` and not `Option<Arc<NodeStore<Committed, FileBacked>>>`?

Originally posted by @danlaine in #697 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rkuris