Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags for network protocol level changes. #440

Open
iansuvak opened this issue Aug 19, 2024 · 1 comment
Open

Add feature flags for network protocol level changes. #440

iansuvak opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM

Comments

@iansuvak
Copy link
Contributor

Context and scope
Current features being developed such as ACP-118 support #383 depend on network level changes that are present in default branches in upstream repos (avalanchego, coreth and subnet-evm).

We need to be able to continue developing on top of these new features while also preserving the ability to push hot fixes and new versions to currently deployed instances of relayer.

To do so we need a configuration setting that determines which protocol level of the network is required for given features.

Discussion and alternatives
Alternatives that were proposed were:

  • Maintained a long-lived dev branch that wouldn't get merged into main until the network upgrade
  • Maintain separate hotfix release branches that would get updated with only the code that needs to get updated for a new feature or bugfix before the next network update.

Both of these seem more cumbersome and error prone than a re-usable feature flag config settings that defaults to the most recent network version live on mainnet.

@iansuvak iansuvak added the enhancement New feature or request label Aug 19, 2024
@iansuvak iansuvak self-assigned this Aug 26, 2024
@iansuvak iansuvak added the Warp Signature API API service for serving arbitrary Warp signatures from any VM label Aug 26, 2024
@iansuvak
Copy link
Contributor Author

iansuvak commented Sep 3, 2024

Implemented in #463 -- Can close once #408 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant