Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: RelayerID declared in database #418

Open
najeal opened this issue Aug 7, 2024 · 0 comments · May be fixed by #421
Open

Refactor: RelayerID declared in database #418

najeal opened this issue Aug 7, 2024 · 0 comments · May be fixed by #421
Labels
enhancement New feature or request

Comments

@najeal
Copy link
Contributor

najeal commented Aug 7, 2024

Context and scope
RelayerID is currently declared in the database package. I think we can find a better place for the type declaration but I did not find a ideal place yet.

Discussion and alternatives
It could be moved in relayer package but it is not possible at the moment as it would create an import cycle. This would require to create some type abstraction to avoid direct dependency.
A temporary work around can be to create new package for the RelayerID but I am not a big fan.

@najeal najeal added the enhancement New feature or request label Aug 7, 2024
@najeal najeal linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog 🗄️
Development

Successfully merging a pull request may close this issue.

1 participant