Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider simplifying the aggregation logic #388

Open
iansuvak opened this issue Jul 26, 2024 · 0 comments
Open

Consider simplifying the aggregation logic #388

iansuvak opened this issue Jul 26, 2024 · 0 comments
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM

Comments

@iansuvak
Copy link
Contributor

iansuvak commented Jul 26, 2024

Context and scope
Current POC implementation of the signature aggregation was based on the existing logic in the relayer. We should consider simplifying and/or improving the logic while working through the other MVP issues. Particularly #382 as it will be modifying the code flow.

Discussion and alternatives
Another existing implementation of the signature aggregation functionality that we can reference is in the subnet-evm repo.

Consider immediately unmarshalling signatures when received instead of in aggregateSignatures
Open questions

@iansuvak iansuvak added the enhancement New feature or request label Jul 26, 2024
@meaghanfitzgerald meaghanfitzgerald added the Warp Signature API API service for serving arbitrary Warp signatures from any VM label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

2 participants