Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint blocks that cannot be processed properly #272

Open
geoff-vball opened this issue May 1, 2024 · 0 comments
Open

Checkpoint blocks that cannot be processed properly #272

geoff-vball opened this issue May 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@geoff-vball
Copy link
Contributor

Context and scope
Currently in listener.go, the select statement checking for new blocks can fail at multiple points and we will just continue and skip processing if there is a networking error or otherwise. This will currently cause us to never checkpoint that block, which means the next time the relayer restarts, it will try to reprocess from that block, which may cause a lot of unnecessary reprocessing.

Any error should probably still checkpoint the block, but we should save that block to attempt to be reprocessed somehow. We can potentially save that block number to the database to attempt to be reprocessed periodically.

Discussion and alternatives
This method of reprocessing can probably be extended in the case where we chose not to process a message because it is not currently profitable, but may be profitable in the future.

Open questions

@geoff-vball geoff-vball added the enhancement New feature or request label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant