-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils.createTestAccounts logic seems to count all network accounts #65
Comments
So the function as is does this: |
The betanet case would always fall under Option 2, right? Or what do you mean by "network that you control", would this heuristic apply to just localnet? How do you see all this working on betanet? |
As an update to this, a conversation with @evgenykuzyakov finally made sense to me. I think ideally we would have the betanet/testnet/localnet create a test account programmatically using the NEAR Contract Helper instead of having the user specify which account should be doing the testing. This is the typical workflow for our other projects, except those have a dedicated |
That makes sense for the test networks where the Contract Helper is already available. However, note that having to install the Contract Helper locally in order to run with localnet would be a major hurdle compared getting set up locally right now. |
It seems as though the
utils.createTestAccounts
method isn't as polished as we'd thought. It'll load all accounts for a network and count that against thenumAccounts
it's supposed to create. This wasn't spotted as easily before since the networklocal
doesn't contain multiple accounts typically.Shouldn't be a difficult task, just making sure to document it so it doesn't get lost.
Update: I think the actual task on this issue is to:
betanet
)The text was updated successfully, but these errors were encountered: