Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source argument from filters #22

Open
Ambrevar opened this issue Jul 4, 2023 · 0 comments
Open

Remove source argument from filters #22

Ambrevar opened this issue Jul 4, 2023 · 0 comments

Comments

@Ambrevar
Copy link
Member

Ambrevar commented Jul 4, 2023

In order to make the API more "functional" (in the mathematical sense), we should not give access to the source.

In fact, filters only ever use source for ensure-match-data-string.
So instead we can call ensure-match-data-string from the match-data reader, possibly closing over source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ambrevar