Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More extensible theme/style system #3516

Open
kchanqvq opened this issue Sep 20, 2024 · 1 comment
Open

More extensible theme/style system #3516

kchanqvq opened this issue Sep 20, 2024 · 1 comment
Labels
feature Feature requests.

Comments

@kchanqvq
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the themed-css facility only allows customization of color scheme, and does not provide a fine-grain modular way to define styles. Effect of changes are only visible after reloading a buffer.

Describe the solution you'd like
I'm working on an Emacs defface style facility (defstyle) which supports deep customization and realtime reloading. I plan to rewrite the current themed-css uses in Nyxt using defstyle. defstyle itself also require some changes to Nyxt core to work better (handling of prompt buffer, etc). Is this kind of contribution candidate for inclusion?

Additional context
Are this kind of significant changes/improvement to Nyxt welcomed at all? If yes, how willing are Nyxt developers to work together to improve the patches until mergeable? What is the feedback time frame I should expect? I'm asking this because I have a few more TODOs like this, however it seems to me that Nyxt is rather unwelcome to open collaboration at this time. I want to make sure everyone's time is productive and well spent. If that's the case, I'll go ahead and maintain my own fork and stop making noise here/waiting for feedbacks. Thank you in advance if you can clarify this!

@kchanqvq kchanqvq added the feature Feature requests. label Sep 20, 2024
@aadcg
Copy link
Member

aadcg commented Sep 20, 2024

Nyxt is undergoing deep architectural changes and theming is something we're not considering at the moment.

We'd be open to proposals after the release of version 4.

Alternatively, it could an extension targeting version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests.
Development

No branches or pull requests

2 participants