Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor architecture behind hide-prompt-buffer #3489

Open
aadcg opened this issue Sep 5, 2024 · 0 comments
Open

Refactor architecture behind hide-prompt-buffer #3489

aadcg opened this issue Sep 5, 2024 · 0 comments
Assignees
@aadcg
Labels
electron ffi Renderer-specific quirks.

Comments

@aadcg
Copy link
Member

aadcg commented Sep 5, 2024

While working on #2989, I've noticed that the logic behind hide-prompt-buffer is intriguing. It calls ffi-buffer-delete, but it's (setf (height prompt-buffer) 0) that makes it disappear, which seems like a violation of ffi-buffer-delete's responsibility. ffi-buffer-delete should delete the renderer buffer object and cease its display.

It's also unclear why buffer-hide exists, see commit e342115. Note that it's only called on the GTK port (which a major red flag).
@aadcg aadcg added ffi Renderer-specific quirks. electron labels Sep 5, 2024
@aadcg aadcg self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadcg aadcg

Labels
electron ffi Renderer-specific quirks.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aadcg