Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete define-class indirection #3481

Open
aadcg opened this issue Aug 27, 2024 · 2 comments
Open

Delete define-class indirection #3481

aadcg opened this issue Aug 27, 2024 · 2 comments
Labels
4-series Related to releases whose major version is 4.

Comments

@aadcg
Copy link
Member

aadcg commented Aug 27, 2024

nclasses is a library maintained by @atlas-engineer/atlas so it's odd that define a macro on top of nclasses:define-class.

We don't need *automatic-types-p* set to t. *accessor-name-package* could easily be set to :slot-name by default. The default value of *predicate-name-transformer* is a good default and we don't to rely on nclasses:always-dashed-predicate-name-transformer.

@aadcg aadcg added the 4-series Related to releases whose major version is 4. label Aug 27, 2024
@jmercouris
Copy link
Member

I think this decision was made pre-fork. I'm not exactly sure the history behind it, there was however some reasoning.

@aadcg
Copy link
Member Author

aadcg commented Aug 28, 2024

@jmercouris that doesn't seem correct since both *automatic-types-p* and *predicate-name-transformer* were for sure included by (past) members of the Atlas team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-series Related to releases whose major version is 4.
Development

No branches or pull requests

2 participants