Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi-display-url may not be needed #3478

Open
aadcg opened this issue Aug 21, 2024 · 0 comments
Open

ffi-display-url may not be needed #3478

aadcg opened this issue Aug 21, 2024 · 0 comments
Labels
4-series Related to releases whose major version is 4. ffi Renderer-specific quirks.

Comments

@aadcg
Copy link
Member

aadcg commented Aug 21, 2024 •
edited
Loading

It's odd that the codebase relies so heavily on render-url. It's a proxy to a foreign function (ffi-display-url), which should only be called at key parts of the program.

After fukamachi/quri@ed2fca8, I wonder if we need ffi-display-url at all.
@aadcg aadcg added ffi Renderer-specific quirks. 4-series Related to releases whose major version is 4. labels Aug 21, 2024
@aadcg aadcg changed the title render-url used too often for no good reason ffi-display-url may not be needed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4-series Related to releases whose major version is 4. ffi Renderer-specific quirks.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aadcg