Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper dropdowns to the Filters Select Menu #1318

Open
akshatnema opened this issue Feb 9, 2023 · 17 comments · May be fixed by #3174
Open

Add proper dropdowns to the Filters Select Menu #1318

akshatnema opened this issue Feb 9, 2023 · 17 comments · May be fixed by #3174
Labels

Comments

@akshatnema
Copy link
Member

Reason/Context

image

So for now, the Filter section when expanded with dropdowns extends a lot in the webpage which creates UI issues for many screens that they have to scroll to click on the Apply Filters button.

Description

Introduce a new Dropdown for these filters so that we have dropdown menus of limited height only but making overflow-y set to scroll with good UI. Each item in the dropdown right now should act as an option in a row for the new dropdown.

@Savio629
Copy link
Contributor

Savio629 commented Mar 7, 2023

Should it look like this @akshatnema

Tools _ AsyncAPI Initiative for event-driven APIs - Brave 07-03-2023 23_26_04 (2)

@reachaadrika
Copy link
Contributor

@akshatnema Can I work on this issue , the PR made for this was also long ago , I can work on this issue ?

@akshatnema
Copy link
Member Author

@reachaadrika Yeah you can work on this issue.

Should it look like this @akshatnema

@Savio629 Yes, it should look like this but the height should be smaller for the dropdown.

@Savio629
Copy link
Contributor

Savio629 commented Mar 26, 2023

@Savio629 Yes, it should look like this but the height should be smaller for the dropdown.

@akshatnema If the elements are more how could we decrease the height for the drop down?
Or do we need to decrease the text size of elements to fit in more dropdown elements?

@ashutosh887
Copy link

I would like to work on this

@Savio629
Copy link
Contributor

@ashutosh887 @sambhavgupta0705 is already working on this pr.
You can hop on some other issues...

@ashutosh887
Copy link

@Savio629 Can you assign me other Good First Issues to please?

@sambhavgupta0705
Copy link
Member

@Savio629 Can you assign me other Good First Issues to please?

You may check out this one : #1581

@whoisvishesh
Copy link

Hey Folks, I want to know, here we were working on building the user interface as described above or trying to find the code logic behind the drop-down?

Though I know @sambhavgupta0705 is already working on this but want to understand the flow in order to help if needed. Do let me know!

@Savio629
Copy link
Contributor

Hey @whoisvishesh,
@sambhavgupta0705 has already made a pr for this issue. You can check it out here -> #1558
We have to suggest some suitable design for the dropdown.

@priyanshu-101
Copy link

@Savio629 can i work on this?

@sambhavgupta0705
Copy link
Member

@priyanshu-101 currently @sagarkori143 is working on this issue
If he drops this then you can work on it

@priyanshu-101
Copy link

Ok
As a fresher can you give me some issues

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 27, 2024
@github-actions github-actions bot removed the stale label Aug 2, 2024
@dhruvkjain
Copy link

@akshatnema is someone still working on this issue as it seems to be stale
If not, I would love to. Do let me know.

@akshatnema
Copy link
Member Author

Yeah, I think @devilkiller-ag is working on it.

@devilkiller-ag
Copy link
Member

Yeah, I think @devilkiller-ag is working on it.

Yes, I am on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment