Skip to content

Commit

Permalink
Improve the makefile setup (#1597)
Browse files Browse the repository at this point in the history
* Remove containers when stopping them

This ensures that starting the setup again picks up the new version of
the image during the next run.

* Clean docker setups in components

The components should be pulling the images they launch and not a
different tag. And they should not try to start the shared localstack
container when the image they use is not localstack. Instead, the should
check for the shared container created by the root Makefile

* Clean all docker images of the root Makefile

* Change the root Makefile to be consistent with services

Instead of having `make stop-docker` triggering the `clean` command
(which also triggers the cleaning of sub-services), it is now `clean`
which depends on `stop-docker` of the root repo.
This brings consistency with initialization commands. We now have a
symmetry between `initialize`/`clean` and `start-docker`/`stop-docker`.
  • Loading branch information
stof committed Oct 27, 2023
1 parent 2612678 commit 54e7421
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ test: initialize
clean: stop-docker
stop-docker:
docker stop async_aws_s3-client || true
docker rm async_aws_s3-client || true

0 comments on commit 54e7421

Please sign in to comment.