Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS crash when opening model #346

Open
ChrisVeigl opened this issue Apr 18, 2021 · 3 comments
Open

ACS crash when opening model #346

ChrisVeigl opened this issue Apr 18, 2021 · 3 comments

Comments

@ChrisVeigl
Copy link
Contributor

just found a very strange bug in the ACS: when opening certain models, e.g.:
https://github.com/asterics/AsTeRICS/blob/master/bin/ARE/models/useCaseDemos/mouseControl/crosshairCursorControl_1key.acs

the ACS crashes with attached error message:

ScreenHunter 46

This does not happen every time, and not on every computer (i have it repeatably on my Desktop PC with a large screen - maybe related to the problem)...

This does not happen in the WebACS.

@klues
Copy link
Contributor

klues commented Apr 19, 2021

Strange, never happened to me.
I think this is the code of interest:
https://github.com/asterics/AsTeRICS/blob/master/ACS/ACS/MainWindow.xaml.cs#L6041

dockEventGrid.Width = dockableComponentProperties.ContainerPane.ActualWidth - 15;
If ContainerPane.ActualWidth is 0, the result width is -15, which is stated in the error message. No idea what the exact meaning is or why ContainerPane.ActualWidth is 0 sometimes.

@ChrisVeigl
Copy link
Contributor Author

thanks for having a look!
could we catch that exception - so that we prevent the ACS from crashing completely ... ?
I have no idea how often (or in which system constellation) the problem occurs - but if it happens, the model can't be used with the ACS at all ...

@klues
Copy link
Contributor

klues commented Apr 20, 2021

Yeah, would make sense to catch the exception or to prevent it by using a default value if 0 is returned. However I've no clue what this code is actually doing, this should be investigated before changing something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants