Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: format_test eager-fetches irrelevant language tooling #329

Open
alexeagle opened this issue Jul 16, 2024 · 0 comments
Open

[Bug]: format_test eager-fetches irrelevant language tooling #329

alexeagle opened this issue Jul 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

What happened?

Implied here: https://github.com/bazel-contrib/bazelrc-parser-go/blob/main/format.bzl#L11-L13

rules_lint by default creates targets for each of these languages (except starlark, which we need to add because it doesn't have a default tool label), which then no-op (but require fetching toolchains and building potentially large runfiles trees).
Ideally it would do this filtering itself in its format_test macro

Version

all versions

How to reproduce

No response

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant