Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error from npm_translate_lock when using pnpm.patchedDependencies #1427

Closed
jfirebaugh opened this issue Jan 4, 2024 · 2 comments
Closed

[Bug]: Error from npm_translate_lock when using pnpm.patchedDependencies #1427

jfirebaugh opened this issue Jan 4, 2024 · 2 comments
Assignees
@kormide
Labels
customer request A request from a customer or potential customer enhancement New feature or request

Comments

@jfirebaugh
Copy link
Contributor

What happened?

If you have a pnpm.patchedDependencies entry in package.json, then npm_translate_lock will produce an error like:

Error in fail: ERROR: patch_args for package @jest/[email protected] contains a strip prefix that is incompatible with a patch applied via `pnpm.patchedDependencies`.

`pnpm.patchedDependencies` requires a strip prefix of `-p1`. All applied patches must use the same strip prefix.

npm_translate_lock's support for pnpm.patchedDependencies should extend to supplying a default patch_args value of ["-p1"] for packages that appear in pnpm.patchedDependencies, since that's the format pnpm uses.

Version

Development (host) and target OS/architectures:

Output of bazel --version: bazel 6.1.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: rules_js-1.33.1

Language(s) and/or frameworks involved: Javascript

How to reproduce

No response

Any other information?

No response
@jfirebaugh jfirebaugh added the bug Something isn't working label Jan 4, 2024
@github-actions github-actions bot added the untriaged Requires traige label Jan 4, 2024
@kormide
Copy link
Member

kormide commented Jan 5, 2024

I have an old PR that does this, but I don't think we reached an agreement: #837.

@alexeagle alexeagle added enhancement New feature or request and removed untriaged Requires traige bug Something isn't working labels Jan 18, 2024
@alexeagle alexeagle added the customer request A request from a customer or potential customer label Feb 22, 2024
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not require patch_args=p1 when only using pnpm patches
af8a2c6 
Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not require patch_args=p1 when only using pnpm patches
cfc3e9a 
Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not require patch_args=p1 when only using pnpm patches
311ff5f 
Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not require patch_args=p1 when only using pnpm patches
9f02432 
Fix aspect-build#1427
@jbedard jbedard mentioned this issue May 3, 2024
Closed
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
1646d68 
…_lock(patches)

Fix aspect-build#1427
@jbedard jbedard mentioned this issue May 3, 2024
Merged
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
cb090e4 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 3, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
52882c0 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 6, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
b58a00d 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 6, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
f7d8fbb 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 7, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
7f5cf33 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 7, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
2d7c130 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 8, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
ca6c6e9 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit to jbedard/rules_js that referenced this issue May 9, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
def576f 
…_lock(patches)

Fix aspect-build#1427
jbedard added a commit that referenced this issue May 9, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
b66dad1 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
@jbedard
Copy link
Member

jbedard commented May 9, 2024

Fixed in #1694

@jbedard jbedard closed this as completed May 9, 2024
gregmagolan pushed a commit that referenced this issue May 10, 2024
@jbedard @gregmagolan
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
f045423 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
gregmagolan pushed a commit that referenced this issue May 10, 2024
@jbedard @gregmagolan
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
29b9afd 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
gregmagolan pushed a commit that referenced this issue May 13, 2024
@jbedard @gregmagolan
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
96902e9 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
jbedard added a commit to jbedard/rules_js that referenced this issue May 14, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
8abac39 
…_lock(patches) (aspect-build#1694)

Fix aspect-build#1427
Close aspect-build#1693
Close aspect-build#837
jbedard added a commit that referenced this issue May 14, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
6dd0376 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
jbedard added a commit to jbedard/rules_js that referenced this issue May 16, 2024
@jbedard
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
68e1333 
…_lock(patches) (aspect-build#1694)

Fix aspect-build#1427
Close aspect-build#1693
Close aspect-build#837
gregmagolan pushed a commit that referenced this issue May 20, 2024
@jbedard @gregmagolan
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
f43be0b 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
gregmagolan pushed a commit that referenced this issue May 20, 2024
@jbedard @gregmagolan
fix: do not support mixing pnpm.patchedDependencies and npm_translate…
bfb2293 
…_lock(patches) (#1694)

Fix #1427
Close #1693
Close #837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kormide kormide

Labels
customer request A request from a customer or potential customer enhancement New feature or request
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not use npm_translate_lock patch_args without patches jbedard/rules_js
4 participants
@alexeagle @jbedard @jfirebaugh @kormide