Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: expression calculations are hydrated 3 times #1444

Open
pinetops opened this issue Sep 7, 2024 · 0 comments
Open

performance: expression calculations are hydrated 3 times #1444

pinetops opened this issue Sep 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pinetops
Copy link
Contributor

pinetops commented Sep 7, 2024

Hydrating expressions is relatively expensive: .5ms is typical in a real app for a first_name <> last_name (although using flame on, so it's probably slowed down by the instrumentation)

There may be opportunities to improve performance of the hydration, but it appears that there are circumstances where the hydration occurs 3 times in a load so if it can be done once, that would improve performance:

Top level:
Screenshot 2024-09-07 at 10 02 30 AM

Zoom in on first two examples:
Screenshot 2024-09-07 at 10 03 07 AM

Zoom in on third example:
Screenshot 2024-09-07 at 10 03 56 AM

@pinetops pinetops added enhancement New feature or request needs review labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Someday
Development

No branches or pull requests

2 participants