Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline methods (member functions) link issues #9

Open
avinash-gupta-in opened this issue Mar 28, 2024 · 1 comment
Open

inline methods (member functions) link issues #9

avinash-gupta-in opened this issue Mar 28, 2024 · 1 comment

Comments

@avinash-gupta-in
Copy link

Many functions are inline, as we know in such case we have to provide the definition within the header file. We are getting link issues with such functions.
https://stackoverflow.com/questions/953710/inline-function-linker-error

@asantoni
Copy link
Owner

asantoni commented Apr 2, 2024

Thanks for bringing this to my attention. You're right, but I won't have time to fix this for a week or two. I would accept a pull request that removes inline from all the functions, if you want to send one over. There's no need for them to be inline and I agree it's done incorrectly and will cause linker issues in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants