From e87ab50603fe40e1285bba574d9d58e7b9c88baa Mon Sep 17 00:00:00 2001
From: Waleed Khan <me@waleedkhan.name>
Date: Sat, 13 Apr 2024 12:15:32 -0700
Subject: [PATCH] build: update MSRV to 1.74

It may become difficult to upgrade dependencies in the future.

- I don't want to fall too far behind. Many automatic dependency updates are now failing, indicating that breaking changes are happening upstream that we haven't integrated.
- Since git-branchless is a CLI application, it doesn't have its downstream dependents to worry about breaking.

The specific value is somewhat arbitrary:

- We're just following `clap`'s current MSRV,
  - which aims to trail the latest Rust version by 6-9 months
    - (and the management of `clap`'s MSRV is its entire own topic).
  - My hope is that many applications in the Rust ecosystem also follow the `clap` MSRV and that packagers have worked out the installation strategy for those applications.
---
 .github/workflows/linux-git-devel.yml | 2 +-
 .github/workflows/linux.yml           | 2 +-
 .github/workflows/macos.yml           | 2 +-
 .github/workflows/windows.yml         | 2 +-
 .gitpod.yml                           | 2 +-
 git-branchless/Cargo.toml             | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/linux-git-devel.yml b/.github/workflows/linux-git-devel.yml
index 75f15a17d..2d290ceb9 100644
--- a/.github/workflows/linux-git-devel.yml
+++ b/.github/workflows/linux-git-devel.yml
@@ -53,7 +53,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.67.0
+          toolchain: 1.74
           override: true
 
       - uses: actions/checkout@v4
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
index e9d3825ef..6be6d46cf 100644
--- a/.github/workflows/linux.yml
+++ b/.github/workflows/linux.yml
@@ -74,7 +74,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.67.0
+          toolchain: 1.74
           override: true
 
       - name: Cache dependencies
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 1bf7dd20e..03f10813e 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -27,7 +27,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.67.0
+          toolchain: 1.74
           override: true
 
       - name: Cache dependencies
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 51457e1d0..50d95dc04 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -20,7 +20,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.67.0
+          toolchain: 1.74
           override: true
 
       - name: Cache dependencies
diff --git a/.gitpod.yml b/.gitpod.yml
index 0b8269432..ee7f8e2c2 100644
--- a/.gitpod.yml
+++ b/.gitpod.yml
@@ -2,7 +2,7 @@ image:
   file: .gitpod/Dockerfile
 tasks:
   - init: |
-      rustup default 1.67.0
+      rustup default 1.74
       cargo test --no-run
       cargo install cargo-insta
       cargo install git-branchless && git branchless init
diff --git a/git-branchless/Cargo.toml b/git-branchless/Cargo.toml
index bf997a09a..f09b3bc67 100644
--- a/git-branchless/Cargo.toml
+++ b/git-branchless/Cargo.toml
@@ -11,7 +11,7 @@ license = "MIT OR Apache-2.0"
 name = "git-branchless"
 readme = "../README.md"
 repository = "https://github.com/arxanas/git-branchless"
-rust-version = "1.67.0"
+rust-version = "1.74"
 version = "0.8.0"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html