Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better management for the PhpKafkaConsumerCommand options #13

Open
joesantos418 opened this issue Aug 25, 2020 · 0 comments
Open

Better management for the PhpKafkaConsumerCommand options #13

joesantos418 opened this issue Aug 25, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@joesantos418
Copy link
Contributor

As pointed out by @DelBianco in the review for #9, we need to handle the options for the PhpKafkaConsumerCommand better. Currently the option "topic" requires an array while giving the impression it requires a string and returning no specific error feedback (there is a generic error, though). We should figure out a better way to handle it.

@joesantos418 joesantos418 added the enhancement New feature or request label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant