Fix linter errors detected by newer versions of golangci-lint #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New versions of golangci-lint are detecting more linter errors, which have been fixed by this changeset. Most linter errors were due to casting between different types of int encodings. For avro wireformat ID, the ID has been set as uint32 (which is being used for decoding). I did a quick search if the avro id should be int or unit, and it seems unspecified. Since we're just matching ID's (to read or write), this should pose no risk.
|
Gosec is pointing out some new false positives that I missed. Will fix it |
|
|
Linting has been fixed |
rjfonseca
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of golangci-lint are detecting more linter errors, which have been fixed by this changeset.
Most linter errors were due to casting between different types of int encodings. For avro wireformat ID, the ID has been set as uint32 (which is being used for decoding). I did a quick search if the avro id should be int or unit, and it seems unspecified. Since we're just matching ID's (to read or write), this should pose no risk.