Refactors errors package #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors.E() function receives a slice of any arguments. This makes this functions very easy to break or cause confusion because each argument must be type casted and processed. Refactors errors.E() to receive the error as the first argument and a list of options. The Code, Op, Severity and KeyValue are now an ErrorOption.
|
eric-reis
approved these changes
May 29, 2024
|
This PR will be automatically closed due to lack of activity. If you think this is a mistake, please reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors.E() function receives a slice of any arguments. This makes this functions very easy to break or cause confusion because each argument must be type casted and processed.
Refactors errors.E() to receive the error as the first argument and a list of options. The Code, Op, Severity and KeyValue are now an ErrorOption.