Adds metrics middleware v4 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new version of the metrics middleware with predefined metrics prefixed with "fkit_" to avoid problems with a collector overwriting labels.
eric-reis
reviewed
Apr 25, 2024
| Metrifier: metrifier.NewDefaultConfig("endpoint", ""), | ||
| } | ||
| config.Metrifier.ConstLabels = map[string]string{ | ||
| "fikt_endpoint": endpoint, |
There was a problem hiding this comment.
RC: fkit is written wrong here
There was a problem hiding this comment.
Fixed it, thank you for noticing
|
Reviewing finished. There's a typo that has impact in the solution and thus must be corrected before merge |
|
eric-reis
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new version of the metrics middleware with predefined metrics prefixed with "fkit_" to avoid problems with a collector overwriting labels.